asbplayer icon indicating copy to clipboard operation
asbplayer copied to clipboard

asbplayer website no longer captures exact frame

Open UmbralCosmos opened this issue 1 year ago • 16 comments

Before submitting an issue check out the common issues section of the README:

The problem only involves the mined picture.

On the website, using shift+ctrl+x to capture a moment and create an anki diologue, the picture is no longer the exact moment but a single frame for a set amount of time.

For example, I can only get 1 specific frame within 1 second, preventing me from getting the exact picture I want.

This was not the case at least a few months ago.

Chrome Version 130.0.6723.59 (Official Build) (64-bit)

Local video

UmbralCosmos avatar Oct 23 '24 07:10 UmbralCosmos

It seems this was addressed but I am still having this problem.

https://github.com/killergerbah/asbplayer/issues/238#issuecomment-1537161090

UmbralCosmos avatar Oct 23 '24 07:10 UmbralCosmos

Is the problem you're experiencing that the 'manually take screenshot' shortcut does not work?

killergerbah avatar Oct 25 '24 12:10 killergerbah

Is the problem you're experiencing that the 'manually take screenshot' shortcut does not work?

No, "you're right, it looks I broke the "current frame" behavior at some point. I've pushed the fix for that; let me know what you think." is the comment I referenced.

When I try to mine the current subtitle, the captured image is not of the frame I'm on. It is the frame at the beginning of the subtitle.

The "manually take screenshot" doesn't work either but I never had any need of it before now anyways.

UmbralCosmos avatar Oct 25 '24 13:10 UmbralCosmos

@UmbralCosmos Unfortunately, I'm unable to reproduce the issue. Are you using https://killergerbah.github.io/asbplayer/ with the latest version of the extension (1.5.0)?

killergerbah avatar Oct 25 '24 22:10 killergerbah

@killergerbah I am not using the extension. Just the website. Only use it with local videos.

UmbralCosmos avatar Oct 26 '24 07:10 UmbralCosmos

@killergerbah It seems this occurs on some types of videos. I have 3 series in .mkv and this issue occurs in only one of them. Having subtitles or not doesn't seem to affect anything. Would you like me to send the video files?

UmbralCosmos avatar Oct 31 '24 09:10 UmbralCosmos

I'm experiencing this exact issue! I can understand why you're not able to replicate it @killergerbah as this only occurs on some shows/files. I downloaded Legend of the Galactic Heroes season 1 from two different users on nyaa, and it happens on both, but not on the prequel movie. Nor on any other local files.

It's exactly as @UmbralCosmos is describing it, it captures the screenshot of the frame at the beginning of the next subtitle. EDIT: I am using https://killergerbah.github.io/asbplayer/ with the latest update, (1.5.0)

mathiaslovnes avatar Oct 31 '24 13:10 mathiaslovnes

If i had a to guess the problem has more to do with seek imprecision related to the video file itself rather than asbplayer screwing up the screenshot logic

Ill look into it more but posting my hypothesis above in case it is consistent with your observations

killergerbah avatar Nov 02 '24 08:11 killergerbah

I'm also having this issue but it started happening in the middle of a show so should be all the same type of file (I started watching Shirokuma Cafe and screenshots were fine but around ep 30 it started having this issue when the screenshot is from the next subtitle)

OscarMatt91 avatar Nov 02 '24 21:11 OscarMatt91

I also have this issue. For some exports I only get 2-3 frames to choose from. Some times these frames go before and or after the actual subtitle. This makes it hard to get a good image when mining that maches the card. I would like to see a more accurate slider that actually seeked the frames of the video if possible.

edit: after using it some more it also does appear that the images are of those in the subtitle after the one being mined. Jumping to the subtitle and using sharex works as a subsitution but is troublesome. plz fix this <3

Blurvy avatar Mar 17 '25 04:03 Blurvy

I have the same issue with some 1080p files, it's late and "Screenshot capture delay" doesn't make any difference.

Geniusssmit avatar Mar 22 '25 22:03 Geniusssmit

For what it's worth I did give this bug a good swing and I cannot figure out why it's happening for the life of me. Seeking the actual video displaying in the player seems to be precise, however seeking with the Anki dialog screenshot adjuster seems to be imprecise. This is despite the APIs being used being basically the same.

killergerbah avatar Mar 28 '25 22:03 killergerbah

The "Manually take screenshot" shortcut does nothing for me personally. Correct me if I'm wrong, but the way you use it is that you go to the timestamp that you want to capture in the video, press the shortcut, then click on the "Mine" button at the top right? Or am I using this wrong?

musjj avatar Aug 15 '25 11:08 musjj

"Manually take screenshot" will only do something if you had mined something before. The shortcut will override the screenshot in the previous card.

killergerbah avatar Aug 20 '25 10:08 killergerbah

So if you use Yomitan, how does this work? I've tried the following:

  1. Pause the video
  2. Scan the word in the subtitle with Yomitan and add it to Anki
  3. Click the "Mine" button at the top
  4. Click on "Update last card"
  5. Seek to the position that you want to screenshot
  6. Press the "Manually take screenshot" shortcut (Ctrl+Shift+V by default)

But nothing happens. I'm using the Firefox extension, so is this some kind of bug?

musjj avatar Aug 20 '25 11:08 musjj

Maybe, can you take a record of what you're doing? That'll make it easier to understand exactly what is happening.

killergerbah avatar Aug 20 '25 19:08 killergerbah