asbplayer icon indicating copy to clipboard operation
asbplayer copied to clipboard

Published 20 hours ago • verified publisher icon killergerbah

Bug with "apply selection" for the sentence field

Open bcatalfo opened this issue 2 years ago • 6 comments

You have to press enter to get it to update correctly Steps to reproduce:

  1. ctrl+shift+x mine a line of dialogue
  2. expand the slider to include the next line
  3. Click the "apply selection" on the audio field to rerecord (turns out this step is vital to reproducing the bug)
  4. click the "apply selection" check mark at the right edge of the sentence field
  5. notice it doesn't update but does if you go in the sentence field and press enter

bcatalfo avatar Jun 24 '22 05:06 bcatalfo

Thank you for reporting this.

killergerbah avatar Jun 24 '22 20:06 killergerbah

@YeezyYeezyWhatsGood What version of the extension are you on?

killergerbah avatar Jun 24 '22 23:06 killergerbah

I am on version 0.18.2

bcatalfo avatar Jun 25 '22 23:06 bcatalfo

I'm not able to reproduce this at the moment. I'll keep an eye out for it though.

killergerbah avatar Jun 26 '22 02:06 killergerbah

I am on 0.19.0 and also encountered this. Here's a clip (I think the video & audio are disabled by DRM):

https://user-images.githubusercontent.com/4437157/181007666-e4b1afbb-b039-4db8-98cc-127328257b0c.mp4

I think the first time I encountered this, the sentence field "apply selection" check mark wasn't even clickable after clicking on the audio field "apply selection" check mark, but I wasn't able to reproduce that the subsequent times.

Hope that helps

apache1123 avatar Jul 26 '22 12:07 apache1123

I am reproducing this regularly. Haven't been able to find the fix though.

killergerbah avatar Sep 14 '22 15:09 killergerbah

I have not observed this issue in a very long time.

killergerbah avatar Mar 01 '24 08:03 killergerbah