killbill-admin-ui icon indicating copy to clipboard operation
killbill-admin-ui copied to clipboard
verified publisher icon killbill

Making Transfer bundle Policy options consistent with API

Open KBbitsP opened this issue 3 years ago • 7 comments

Issue : Currently when a bundle is transferred from one account to another using Kaui, the screen does not give any option to select the transfer policy and uses End_Of_Term as the default value. On the other hand, the same operation when performed via the API gives the option to select out of Start_Of_Term, Immediate OR End_Od_Term policy just like at the time of cancelling.

image

Expected behavior : The behavior and options should be consistent between the admin ui and the API ( https://killbill.github.io/slate/#bundle-transfer-a-bundle-to-another-account ).

KBbitsP avatar Oct 03 '22 16:10 KBbitsP

This is interlinked to the below issue :

https://github.com/killbill/killbill/issues/1775

KBbitsP avatar Oct 03 '22 17:10 KBbitsP

Screenshot 2022-10-04 at 13 26 15

kpbacode avatar Oct 04 '22 11:10 kpbacode

https://github.com/killbill/killbill-admin-ui/pull/321

kpbacode avatar Oct 06 '22 07:10 kpbacode

Looks good (see screenshot below). A few comments:

  1. Currently, the billing policy defaults to IMMEDIATE. Wondering if we should default it to END_OF_TERM to keep it consistent with the API?
  2. As per @KBbitsP, there is an issue when the START_OF_TERM policy is specified (#1775). So, should the START_OF_TERM policy be disabled in Kaui until this issue is fixed?
image

reshmabidikar avatar Oct 14 '22 08:10 reshmabidikar

Any thoughts @pierre?

reshmabidikar avatar Oct 18 '22 05:10 reshmabidikar

Agreed x2!

pierre avatar Oct 18 '22 11:10 pierre

FYI @kpbacode.

reshmabidikar avatar Oct 18 '22 13:10 reshmabidikar