Patrick Strawderman

Results 46 comments of Patrick Strawderman

From the spec you linked to: > An input field is required if it has a non‐null type and does not have a default value. So technically a non-null type...

I put together some [test cases to validate this](https://gist.github.com/kilink/9ff125664108565b83e1f04f54602086), maybe it illustrates it a bit better. For this schema a nullable type for color: ```graphql input ColorFilter { color: String...

I think this was already reported in #355, although I suppose you consider it a different problem since it's reporting usage at the top level. It worked before we switched...

@codefromthecrypt when I look into it, we aren't adding new extra instances here, it's typically 3 items from the root span. The issue is when creating a child span, the...

> While possible to do `.addExtra(x).addExtra(y)` this so far doesn't seem like the expected use. We aren't doing that directly, that is happening in ExtraFactory decorate, because of how the...

I looked into this a bit, and I don't think it's a bug in DGS or graphql-java, but maybe a misunderstanding with how DataLoaders work. When you call the load...

I believe this issue was fixed in v8.2.5 (see #1802). What version of DGS are you on?

Sure, I can get the CLA signed; but also I realized that `ImmutableIntArray` / `ImmutableDoubleArray` were added in Guava 22.0, so this change cannot really be merged anyway if the...

> @kilink One possibility: postpone Guava baseline upgrade to Jackson 2.19, merge this in after 2.18.0 released? This gives us more time. I'm fine with that. Not really an urgent...

I think as designed, `InputObjectMapper` cannot work for your use case, as it deals with classes instead of types; e.g., the type variable F can only be resolved with the...