remix-flat-routes icon indicating copy to clipboard operation
remix-flat-routes copied to clipboard

Published 20 hours ago • verified publisher icon kiliman

fix fixupIndexRoutes function args type

Open oats7777 opened this issue 1 year ago • 2 comments

The type of parameter in the fixupIndexRoutes function changed from any to RouteManifest. This is because I think it is better to increase safety by specifying a specific type rather than using any in type script.

oats7777 avatar Apr 04 '23 07:04 oats7777

I think we can remove this function altogether. This was here because an older version of Remix was checking for index routes by looking for route id ending with '/index'. Current versions now use the index flag from the route manifest.

kiliman avatar Apr 04 '23 14:04 kiliman

I think we can remove this function altogether. This was here because an older version of Remix was checking for index routes by looking for route id ending with '/index'. Current versions now use the index flag from the route manifest.

Can I understand that after the PR below is merged, I can remove the function and make a new implementation that fits the new index flag from the route manager?

https://github.com/remix-run/remix/pull/3127

oats7777 avatar Apr 05 '23 00:04 oats7777