middleclass icon indicating copy to clipboard operation
middleclass copied to clipboard

Create `lua/middleclass.lua` symlink to origin file

Open anuvyklack opened this issue 1 year ago • 5 comments

To make middleclass git repo work with Neovim plugin managers.

anuvyklack avatar Sep 01 '22 08:09 anuvyklack

This symlink approach unfortunately doesn't work on Windows OS. To prevent Noevim plugin authors from unintentionally breaking plugins on Windows, a different approach will be required to allow this repo to be used as a dependency in new Neovim plugins.

Issafalcon avatar Sep 20 '22 13:09 Issafalcon

In my opinion, windows users can just do git config --global core.symlinks true as a user-wide setting.

But why don't we move ROOT/middleclass.lua -> ROOT/lua/middleclass.lua if out-of-box support for windows users is a concern? (and put a symlink into ROOT). Actually I don't see any reason the file middleclass.lua must be placed on the root directory.

wookayin avatar Sep 20 '22 16:09 wookayin

Everything ingenious is simple!

anuvyklack avatar Sep 20 '22 16:09 anuvyklack

Good solution! The git config update would have been fine, with some additional README updates, but this way is much better.

Issafalcon avatar Sep 20 '22 18:09 Issafalcon

Why still have the symlink at all? My experience is that will break more cases than it fixes. I would suggest just putting the file where it is usable by all relevant consumers in the first place and adjust usage to assume that location.

alerque avatar Sep 23 '22 07:09 alerque