klayjs-d3 icon indicating copy to clipboard operation
klayjs-d3 copied to clipboard

Any plans to make klayjs-d3 compatible with d3-v4?

Open rcoaguila opened this issue 8 years ago • 4 comments

Hi, I would like to use this library but my project uses d3-v4. I saw in issue #11 that the version was fixed to ^3.5.0, are there any plans to make it compatible with v4? Or can you provide me some pointers to make this change?

Thanks!

rcoaguila avatar Feb 13 '17 11:02 rcoaguila

Yes. Although I don't know when I find time for it. Currently the klayjs-d3 script assumes that the d3 object exists and calls its rebind method. With v4 one has to properly import the d3 object I guess.

uruuru avatar Feb 13 '17 11:02 uruuru

I where able quite easily to use klay-3d with v4 the only big changes is that on the dispatch events you need to us call instead of just using the finish event. as this dispatch.call('finish', foo). I have a working fork over here. https://github.com/AnthonyDry/klayjs-d3/tree/fixesForD3V4

Im terrible att pull-request and Im not sure how the ww should work, so it might be better if someone else do a proper rewrite later.

Best regards!

AnthonyDry avatar Feb 13 '17 20:02 AnthonyDry

Is there any place to find klayjs source code to fix it. Complete javascript not build one.

chandusekhar avatar May 26 '17 11:05 chandusekhar

klayjs is based on Java code, not Javascript. See #16 for the Java source and its documentation for reasons why we do not provide new builds at the moment.

uruuru avatar May 29 '17 10:05 uruuru