elkjs icon indicating copy to clipboard operation
elkjs copied to clipboard

Fixed vulnerability for 0.10.1 release

Open soerendomroes opened this issue 6 months ago • 3 comments

Do not merge this.

@Eddykasp please review this. If you think it looks fine, I will continue with the release of elkjs 0.10.1.

soerendomroes avatar Jun 25 '25 10:06 soerendomroes

I think it's fine, just a question why is the lockfile version being updated and shouldn't this then also happen on the master? Is this a result of building with a newer npm version or something like that?

Eddykasp avatar Jun 25 '25 12:06 Eddykasp

And for the release, the built files in the lib folder need be force added to this branch

Eddykasp avatar Jun 25 '25 12:06 Eddykasp

I think it's fine, just a question why is the lockfile version being updated and shouldn't this then also happen on the master? Is this a result of building with a newer npm version or something like that?

I do not think that it matters since this branch will never be merged back.

I am just changing the package.json and rebuilding. Everything else is handled by npm. Maybe since the version changed, the lockversion is reset to 1?

soerendomroes avatar Jun 25 '25 14:06 soerendomroes