kie-wb-common icon indicating copy to clipboard operation
kie-wb-common copied to clipboard

Fix Whitespace Issue in Migration Tool

Open arkitex opened this issue 2 years ago • 21 comments

Fix an issue with the Migration Tool throwing errors on group names with whitespace in it.

Ran into this issue when migrating a 6.x project to 7.66.0. We had a Project name with a space in it (Ex: Example Project). The URI.create method called by the migration tool (way down in the call stack, in org/guvnor/structure/backend/organizationalunit/config/SpaceConfigStorageImpl.java) fails on whitespace, whoops!

As a fix, URLEncode the group name immediately upon launching the migration script.

Also, do it when moving data to the space config repo - unfortunately gotta do it in two places.

Tested through migrating previously failing project - this time, it passed.

arkitex avatar May 18 '22 21:05 arkitex

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

Can one of the admins verify this patch?

kie-ci avatar May 18 '22 21:05 kie-ci

it would be nice to provide also a unit test for this change @arkitex

ok to test

mareknovotny avatar Aug 27 '22 07:08 mareknovotny

jenkins retest this please

mareknovotny avatar Jun 06 '24 10:06 mareknovotny

Error:

[Pipeline] { (Sonar analysis)
[Pipeline] tool
[2024-06-06T11:38:07.463Z] Invalid tool ID 20.14.0
[Pipeline] envVarsForTool
[2024-06-06T11:38:07.508Z] Invalid tool ID 20.14.0

Jenkins retest this please

mareknovotny avatar Jun 06 '24 12:06 mareknovotny

unfortunately newer nodejs requires specific glib and C++ libraries installed so we have an error there:

[2024-06-06T11:03:27.460Z] [INFO] Detected os: Linux arch: amd64 alpine: false. Platform: LINUX_X64
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [WARNING] Embedded Node.js failed to deploy. Will fallback to host Node.js.

mareknovotny avatar Jun 07 '24 13:06 mareknovotny

jenkins retest this please

testing nodejs 18.20.2 for Sonar analysis

mareknovotny avatar Jun 11 '24 12:06 mareknovotny

jenkins retest this please

mareknovotny avatar Sep 03 '24 12:09 mareknovotny

jenkins retest this please

pibizza avatar Sep 17 '24 14:09 pibizza