kie-cloud-operator icon indicating copy to clipboard operation
kie-cloud-operator copied to clipboard

Published 20 hours ago • verified publisher icon kiegroup

[KIECLOUD-422] move admin user/pwd to statusDescriptors

Open tchughesiv opened this issue 4 years ago • 11 comments

Dependant on https://github.com/openshift/console/pull/6697

We'll need to wait for a later operator release. Once the above is merged. Then, we'll need to target the operator version that aligns with whatever OCP version these console password type enhancements are released with. Which appears to be 4.7.

Screen Shot 2020-09-21 at 11 06 42 AM

Signed-off-by: tchughesiv [email protected]

tchughesiv avatar Sep 21 '20 14:09 tchughesiv

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot avatar Sep 21 '20 14:09 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot avatar Sep 21 '20 14:09 openshift-ci-robot

What happened here? Did you change your strategy RE displaying the default RedHat password to users?

bmozaffa avatar Sep 21 '20 17:09 bmozaffa

What happened here? Did you change your strategy RE displaying the default RedHat password to users?

@bmozaffa yes... further testing reveals that randomly generated passwords (the most important ones to display) are in status only.

unfortunately, the password type is not currently supported in statusDescriptors... so i've submitted a PR to add it. https://github.com/openshift/console/pull/6697

tchughesiv avatar Sep 21 '20 17:09 tchughesiv

/lgtm

bmozaffa avatar Sep 21 '20 17:09 bmozaffa

/lgtm

bmozaffa avatar Sep 22 '20 15:09 bmozaffa

New changes are detected. LGTM label has been removed.

openshift-ci-robot avatar Sep 25 '20 20:09 openshift-ci-robot

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

sonarqubecloud[bot] avatar Sep 25 '20 20:09 sonarqubecloud[bot]

@tchughesiv: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 03 '20 22:10 openshift-ci-robot

@tchughesiv: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/lint 998eb09ec6fb75cb562f9d96582f1214f75e17e0 link /test lint
ci/prow/vet 998eb09ec6fb75cb562f9d96582f1214f75e17e0 link /test vet
ci/prow/format 998eb09ec6fb75cb562f9d96582f1214f75e17e0 link /test format
ci/prow/images 998eb09ec6fb75cb562f9d96582f1214f75e17e0 link /test images
ci/prow/configs 998eb09ec6fb75cb562f9d96582f1214f75e17e0 link /test configs
ci/prow/mod 998eb09ec6fb75cb562f9d96582f1214f75e17e0 link /test mod
ci/prow/unit 998eb09ec6fb75cb562f9d96582f1214f75e17e0 link /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 26 '21 20:01 openshift-ci[bot]

i guess we can close this as outdated, right @tchughesiv

mareknovotny avatar Feb 29 '24 08:02 mareknovotny