jbpm-wb icon indicating copy to clipboard operation
jbpm-wb copied to clipboard

Use containsOnly insead of containsExactly in ProcessInstanceDiagramPresenterTest.java

Open cpugputpu opened this issue 4 years ago • 17 comments

The test in org.jbpm.workbench.pr.client.editors.instance.diagram.ProcessInstanceDiagramPresenterTest#testOnProcessInstanceSelectionEvent can fail due to a different iteration order of Map. The failure is presented as follows: java.lang.AssertionError: Actual and expected have the same elements but not in the same order, at index 0 actual element was: <MapEntry[key="_2", value=1L]> whereas expected element was: <_1=1>

The fix is to use containsOnly instead of containsExactly so that the iteration order of Map does not make the assertion fail. In this way, the test will be more robust, and the failure above will be removed.

cpugputpu avatar May 11 '20 15:05 cpugputpu

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

kie-ci avatar May 11 '20 15:05 kie-ci

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

kie-ci avatar May 11 '20 15:05 kie-ci

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

kie-ci avatar May 11 '20 15:05 kie-ci

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

kie-ci avatar May 11 '20 15:05 kie-ci

ok to test

mareknovotny avatar Aug 25 '22 11:08 mareknovotny

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci

Can one of the admins verify this patch?

kie-ci avatar Aug 25 '22 11:08 kie-ci