github-action-build-chain icon indicating copy to clipboard operation
github-action-build-chain copied to clipboard

forked projects with different name not related with base repository are not being considered

Open Ginxo opened this issue 4 years ago • 6 comments

We are considering forked projects:

  • the ones related with the base repository (appears on the forked project list)
  • the ones with the same name as the base repository

Still pending:

-the ones with the different name as the base repository and not related with it

@jsoref https://github.com/jsoref/ suggested a very interesting approach we should at least consider https://github.community/t/github-api-getting-fork-project-for-a-specific-user/185441/3?u=ginxo

Ginxo avatar Jun 18 '21 06:06 Ginxo

wondering whether we should consider to treat this case... :thinking:

Ginxo avatar Nov 03 '21 06:11 Ginxo

wasn't this already fixed in #156 ?

mareknovotny avatar Oct 09 '23 08:10 mareknovotny

Dunno :). Sadly GitHub didn't leave enough breadcrumbs for me to be able to recall what I suggested... -- it's likely my suggestion was to check to see if two commits were reachable for the same sha across the fork world (with the same content...), as generally github has treated connected repositories as a single repository. (Amusingly, github's current search engine currently treats identical individual documents from unrelated repositories as equivalent -- this is discernible today because the counts don't treat them as distinct when a search hits each of them...)

I will say that it's possible for a user to have:

  • a repository with the same name as your repository that isn't related
  • two (or presumably more, although I haven't managed to do this yet...) forks of your repository with other names (!!) -- please don't ask how, but I've managed to do it a couple of times of late, so apparently the naive assumption that I (and probably everyone else) had that there'd be at most one related fork per user is well, just that ...

jsoref avatar Oct 11 '23 07:10 jsoref

so @jsoref to summarize you still have this issue with a repository not being considered, right?

mareknovotny avatar Oct 11 '23 09:10 mareknovotny

I don't think I use this action. I'm here because I use lots of repositories and was involved in GitHub's prototype community. I offered input based on a question and someone filed this issue and tagged me.

It should be easy enough to test to confirm...

jsoref avatar Oct 11 '23 12:10 jsoref

ok, thanks for clarifying

mareknovotny avatar Oct 11 '23 13:10 mareknovotny