droolsjbpm-integration icon indicating copy to clipboard operation
droolsjbpm-integration copied to clipboard

[windows_codegenpath] test output path on windows

Open gitgabrio opened this issue 3 years ago • 5 comments

Testing source output on windows

gitgabrio avatar Jun 14 '21 12:06 gitgabrio

Jenkins retest this

gitgabrio avatar Jun 14 '21 13:06 gitgabrio

@gitgabrio I'm afraid we have the same issue we had in the past

2021-06-15T07:31:40.1651042Z Caused by: java.io.IOException: Cannot run program "C:\hostedtoolcache\windows\jdk\8.0.292\x64\jre\..\bin\javadoc.exe" (in directory "D:\a\droolsjbpm-integration\droolsjbpm-integration\kiegroup\droolsjbpm_integration\kie-server-parent\kie-server-services\kie-server-services-task-assigning\kie-server-services-task-assigning-user-system\kie-server-services-task-assigning-user-system-api\target\apidocs"): CreateProcess error=267, The directory name is invalid

Ginxo avatar Jun 15 '21 08:06 Ginxo

@Ginxo Yup, I see. Reason for that PR was exactly to verify what may happen in windows machine. Some failures may be ignored (e.g. javadoc creation may happen just inside our "build" machines) but other code-path is expected to run on customer machine (e.g. maven-plugin execution). Main issue is that currently it seems we are not verifying what happen on windows, and it is a bit of concern from my point of view. I think a more structured approach is needed. @mariofusco @danielezonca WDYT ?

gitgabrio avatar Jun 15 '21 08:06 gitgabrio

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 15 '21 10:06 sonarqubecloud[bot]

@Ginxo Yup, I see. Reason for that PR was exactly to verify what may happen in windows machine. Some failures may be ignored (e.g. javadoc creation may happen just inside our "build" machines) but other code-path is expected to run on customer machine (e.g. maven-plugin execution). Main issue is that currently it seems we are not verifying what happen on windows, and it is a bit of concern from my point of view. I think a more structured approach is needed. @mariofusco @danielezonca WDYT ?

I think making the whole -integration repo compatible with a windows build will require quite a lot of work, it is probably easier create a specific profile and configure a windows job that uses that profile. For example I agree that kie-maven-plugin should be tested also with Windows.

danielezonca avatar Jun 15 '21 12:06 danielezonca

Could we close this PR?

mareknovotny avatar Feb 16 '23 09:02 mareknovotny

I think so, it is quite old and the repo is sort of EOL

danielezonca avatar Feb 16 '23 09:02 danielezonca

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Feb 16 '23 12:02 sonarqubecloud[bot]