ios-oss icon indicating copy to clipboard operation
ios-oss copied to clipboard

[PAY-1829] Card Selection With Newly Created Payment Sheet Cards

Open msadoon opened this issue 2 years ago • 2 comments

📲 What

This PR address the selection logic of picking a card after it has been added via the new payment sheet.

🤔 Why

User should see newly added card for project with/without backing pre-selected. User should also be able to pick between pre-existing cards and newly created ones. (Both with the payment sheet and no).

🛠 How

...will explain after completed coding pr...

👀 See

Trello, screenshots, external resources?

Before 🐛

..coming..

After 🦋

..coming..

✅ Acceptance criteria

With ios_payment_sheet ON

  • [ ] User is able to add a new card through payment sheet, select it (or any pre-existing card) within the pledge page only for the .pledge context

With ios_payment_sheet OFF

  • [ ] User is able to add a new card through add new card screen, select it (or any pre-existing card) within the pledge page only for the .pledge context

⏰ TODO

  • [x] Allow manual selection of new payment sheet cards
  • [ ] Pass through data into the pledge cta context so its' prepared for the createBacking mutation.

msadoon avatar Aug 10 '22 19:08 msadoon

@scottkicks Hey Scott, just getting the hang of adding you to new PR's -- no need to review it or anything, feel free to post questions/comments if you want.

msadoon avatar Aug 10 '22 19:08 msadoon

1 Warning
:warning: Big PR

Generated by :no_entry_sign: Danger

nativeksr avatar Aug 10 '22 23:08 nativeksr

Codecov Report

Merging #1711 (b9c6ca6) into main (0049919) will increase coverage by 0.03%. The diff coverage is 91.27%.

@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   85.23%   85.26%   +0.03%     
==========================================
  Files        1269     1269              
  Lines      113329   113813     +484     
  Branches    30068    30143      +75     
==========================================
+ Hits        96598    97046     +448     
- Misses      15684    15721      +37     
+ Partials     1047     1046       -1     
Impacted Files Coverage Δ
...ws/Cells/PledgePaymentSheetPaymentMethodCell.swift 0.00% <0.00%> (ø)
...PledgePaymentSheetPaymentMethodCellViewModel.swift 0.00% <0.00%> (ø)
...ntrollers/PledgePaymentMethodsViewController.swift 49.15% <7.14%> (-3.58%) :arrow_down:
...ary/ViewModels/PledgePaymentMethodsViewModel.swift 96.22% <95.02%> (-0.72%) :arrow_down:
...iewModels/PledgePaymentMethodsViewModelTests.swift 97.49% <95.90%> (-0.88%) :arrow_down:
...aSources/PledgePaymentMethodsDataSourceTests.swift 99.12% <100.00%> (+0.23%) :arrow_up:
...aphAPI.CreateBackingInput+CreateBackingInput.swift 100.00% <100.00%> (ø)
...I.CreateBackingInput+CreateBackingInputTests.swift 100.00% <100.00%> (ø)
KsApi/mutations/inputs/CreateBackingInput.swift 100.00% <100.00%> (ø)
...Api/mutations/inputs/CreateBackingInputTests.swift 100.00% <100.00%> (ø)
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 12 '22 05:08 codecov[bot]