android-oss
android-oss copied to clipboard
WEB-663 : [Android] Remove the ability to log in with Facebook
📲 What
[Android] ask user to reset password with facebook login error
https://www.figma.com/file/lmJlSlEk5Wp7BfxCVtKplU/Deprecrating-FB-Authentication?node-id=192%3A2368
🤔 Why
Facebook login completely unavailable due to revoked API, user clicks FB CTA
🛠How
Check under feature flag with facebook login error to show dialog to user to reset password or login normally
👀 See
https://user-images.githubusercontent.com/1075310/184010350-04676813-27d4-4e77-bbcb-a27e47bbdbce.mp4
📋 QA
Test on staging as we already have facebook error and feature flag enabled to work as demo Test production with normal flow login with facebook
Story 📖
https://kickstarter.atlassian.net/browse/WEB-663
Codecov Report
Merging #1669 (467ec36) into master (b4aef0a) will increase coverage by
0.02%
. The diff coverage is85.00%
.
@@ Coverage Diff @@
## master #1669 +/- ##
============================================
+ Coverage 78.43% 78.45% +0.02%
- Complexity 1875 1877 +2
============================================
Files 356 357 +1
Lines 16849 16921 +72
Branches 2122 2135 +13
============================================
+ Hits 13215 13276 +61
- Misses 2397 2404 +7
- Partials 1237 1241 +4
Impacted Files | Coverage Δ | |
---|---|---|
...com/kickstarter/ui/activities/LoginToutActivity.kt | 100.00% <ø> (ø) |
|
...a/com/kickstarter/viewmodels/LoginToutViewModel.kt | 75.53% <74.07%> (+0.10%) |
:arrow_up: |
...m/kickstarter/viewmodels/ResetPasswordViewModel.kt | 89.87% <85.29%> (-4.25%) |
:arrow_down: |
...com/kickstarter/libs/utils/extensions/IntentExt.kt | 89.79% <100.00%> (+2.61%) |
:arrow_up: |
...om/kickstarter/ui/data/ResetPasswordScreenState.kt | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more