fraidycat icon indicating copy to clipboard operation
fraidycat copied to clipboard

Duplicate subscriptions occasionally appear

Open emceeaich opened this issue 5 years ago • 9 comments

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Firefox Nightly
  • Version: 75

Describe the bug

  • From Fraidycat, subscribe to a YouTube channel by nickname link
    • https://www.youtube.com/user/4ADRecords
  • Return to Fraidycat after a browser restart or some time
  • Expected result
    • One section on page for subscribed channel
  • Actual result
    • Two sections on page for subscribed channel, both URLs under the UID of the channel, not the nickname

emceeaich avatar Feb 25 '20 18:02 emceeaich

The channel URL is correct - Fraidycat translates user URLs into channel URLs. I may be able to use the original URL - but it's a low priority at the moment.

However, the duplicates issue is something I see crop up from time to time. This has to do with my templates - it should allow only one entry for every ID, but I see this sometime. If I can reproduce it, I will fix it - but your steps didn't get me there quite yet.

But yeah. Thank you for this useful information!

kickscondor avatar Feb 25 '20 19:02 kickscondor

Ok was just able to make this happen with a Twitch follow.

Basically, when I visit its proper tab, two appear. Then I move to other tabs and the copy appears on those tabs (no matter the label or 'importance'). The copy appears to be out of date. So I am guessing this is a race condition. The copy is meant to be replaced, but instead becomes an orphan of some kind - without a key

I've got a second follow doing it now - a Reddit link. The copies also aren't sorted properly. (The subreddit shows a time of '3h' but is beneath follows that show '1d'.)

kickscondor avatar Feb 25 '20 19:02 kickscondor

Removing the 'key' to prevent duplicates using a hash has solved this for me. Firefox should update soon - if we continue to see it, I have some ideas for tracking it further.

kickscondor avatar Feb 25 '20 21:02 kickscondor

This is still a problem. I get duplicates that go away when I refresh. Could still be a bug in Hyperapp - unlikely though. I think there are duplicate entries in follows.all. Perhaps the JSON patching is failing. The IDs appear to be fine though.

kickscondor avatar Feb 29 '20 23:02 kickscondor

Hi! First off, thank you so much for creating this awesome extension. It has really made following some great content creators a lot easier :)

I'm still experiencing this issue, but only with a couple of blogs - my own, and that of Marios Fakiolas image

poacher2k avatar Aug 03 '20 08:08 poacher2k

Hi, thank you for reporting this.

Roughly when did these duplicates appear? Just in the last few days?

medicinecal avatar Aug 03 '20 14:08 medicinecal

@medicinecal : They have been appearing from time to time over the last couple of months. When reporting this issue yesterday, I was on my work laptop and deleted -> re-added both those blogs. Right after re-adding there are only 1 of each. Now, on my home computer, one of the blogs have again become duplicate.

image

poacher2k avatar Aug 04 '20 06:08 poacher2k

I am also still getting these duplicates fairly frequently, although with Youtube channels.

For me, it appears to happen mostly when I open Fraidycat on another device. If I delete the duplicates from my main PC, close the tab and then open the laptop, I find duplicates on the laptop.

Oddly, its only on the one section and it isn't every entry, although it does appear to affect the entries one by one. The next time I check there may be the original duplicate and one additional one.

Additional information if it is at all helpful:

  • Collection has an emoji name
  • URLs are always identical
  • No custom title set
  • Importance is real-time

If I can provide anything else to help, let me know.

richardtatum avatar Aug 12 '20 22:08 richardtatum

@richardtatum Brilliant! Thank you for these details. I have been able to repro this, so hopefully I can get a fix together soon.

medicinecal avatar Aug 13 '20 20:08 medicinecal