pushy icon indicating copy to clipboard operation
pushy copied to clipboard

Published 20 hours ago • verified publisher icon kibu-australia

Preserve fragments in URLs

Open magnars opened this issue 7 years ago • 2 comments

When URLs have fragments in them, pushy used to discard them. This change preserves the fragment. Example:

<a href="/a-page#some-header">

Pushy would go to just /a-page before this change.

magnars avatar Mar 15 '17 13:03 magnars

This turns out to not be a complete fix. The getToken function in the goog history API does not include the hash, so the initial dispatch does not include the hash. Hmfr.

magnars avatar Mar 15 '17 13:03 magnars

Thankfully it wasn't goog.History that omitted the initial hash, so I was able to mend this easily enough. This PR is now good again. :)

magnars avatar Mar 16 '17 10:03 magnars