Igor Savin

Results 407 comments of Igor Savin

So if there are no objections, I can start with GitHub Actions migration and Docker-based tests, that will speed up iteration for remaining items. What's the main communication channel for...

@lbdremy Thanks! Trying to run tests on Docker solr image, no success so far. Does `solr-node-client` only support up to Solr 4.x? The oldest Docker image is for 5.x.

What happens currently? Since this violates spec, I wonder if throwing a very explicit error is not a better option.

@Uzlopak RFC does not cover any part of error handling, and I don't think that Multer spec is a thing. I would say it's more of a good engineering practice,...

I am open to both approaches - keeping 1.0.0 as drop-in replacement for busboy, and following up with 2.0.0 which is way stricter about what it accepts, or introducing "strict"...

As discussed, can we start throwing errors there?

I agree that we should be strict and throw an error for these cases, configuration doesn't seem necessary, as this case directly violates spec

thank you! could you send a pr for this?

@mcollina reducing amount of dependencies is not a good thing on its own?

@philsturgeon https://github.com/PayU/openapi-validator-middleware/blob/22b02fa6bb549a69b9c55719bbdf748debd8fb81/test/express/test-server-keywords.js is this the kind of custom keywords support that you are talking about?