Igor Savin

Results 407 comments of Igor Savin

Can you remind me if legacy tests provide extra coverage over what non-legacy tests do, that you consider useful?

we should migrate them, then, and then we can drop the legacy ones

@dominictarr do you need any help with reviewing/merging this PR?

@mafintosh Would you like some help with maintaining the library?

@davidmarkclements Should this be mentioned in readme of the project, perhaps? I can run benchmark using https://github.com/kibertoad/photofinish in order to accumulate info per Node version.

Yup, this breaks for CommonJS import resolution: ``` Error: test/publishers/SnsPermissionPublisher.spec.ts(7,26): error TS2307: Cannot find module 'sqs-consumer' or its corresponding type declarations. There are types at '/home/runner/work/message-queue-toolkit/message-queue-toolkit/node_modules/sqs-consumer/dist/types/index.d.ts', but this result could...

@nicholasgriffintn Thank you, it works now!

I can do this together with undici conversion then

@arjunkomath Effort required for this was too big, I don't think I can realistically handle that in the end, unfortunately :-/

@IamLizu How about replacing `qs` with `neoqs`? https://github.com/puruvj/neoqs