Igor Savin

Results 407 comments of Igor Savin

@mjsalinger Could you review those CI failures and address if needed?

Can you elaborate on what you are suggesting? But yeah, circular dependencies should be avoided

I've created a fork of the project with the aim to address all known issues with uri-js: https://github.com/kibertoad/toad-uri-js Would you be open to contribute a fix for this security vulnerability?

@anonrig Big and important use-case for programmatic API is setup hooks for testing frameworks, such as vitest or jest.

@tniessen I mean being able to put an equivalent of `require('dotenv').config()` inside a hook :D

@tniessen That would be an understandable limitation of JS API. But if native .env support can't be used from JS userspace, then users will still need to depend on `dotenv`...

Locally this fix https://github.com/r3b/grunt-protractor-coverage/pull/67 fixes the Protractor 3.3.0 for me.

@thorhj Can you check the repro here? It isn't failing for me even on the old zod-to-json-schema. What am I missing?

So tests were passing, but TS build was not. So I ended up just synchronizing the versions; guess it's not worse than it was before anyway.

@thorhj If I publish a prerelease version with this, will you be able to confirm it works as expected?