Kirtana Ashok
Kirtana Ashok
> @kiashok Yep! I'll try and get to this tomorrow evening Thanks Danny!
> Today's lookin a little slammed.. 🫠I'll definitely get to this sometime this week @kiashok (please ping if I don't) Sure Danny no worries, thanks a lot! :)
> @kiashok I'll try and get a final pass sometime this week. Thanks for looking at the feedback! > @kiashok I'll try and get a final pass sometime this week....
@mxpv could you please take a look at the new changes and see if they look good? Also, the CI failures seem to be unrelated to the change
Looks like I accidentally deleted the fork that had the branch with the changes in this PR. Addressed the comments that @dmcgowan left this morning and wanted to submit new...
We are actively looking into this. Don't have a timeline yet - will share more details on this once we have them.
@swagatbora90 Looks like all the PR comments were addressed. Do we know if anything is blocking sign offs? Was trying to add some logs to these APIs and came across...
Fixed by https://github.com/containerd/containerd/pull/8198 , https://github.com/containerd/containerd/pull/9317 (fixing a some changes that missed making it to pkg/cri/sbserver and containerd/main has not switched to sbserver and sbserver has been renamed to pkg/cri/server) ....
@stevenjh are you still actively hitting this problem? Are you using ACI?
> Fixed by #8198 , #9317 (fixing a some changes that missed making it to pkg/cri/sbserver and containerd/main has not switched to sbserver and sbserver has been renamed to pkg/cri/server)...