kiali icon indicating copy to clipboard operation
kiali copied to clipboard

Include inbound and outbound edges when automatically activating rank in the graph

Open leandroberetta opened this issue 3 years ago • 5 comments

When a user wants to use the ranking feature in the graph and for example types a rank query in the find section, if rank is not activated, Kiali will activate it and alert the user about this:

In the following scenario, ranking is not activated:

image

Then, the user types an expression in the find field, using the rank feature:

image

But as a result nothing is highlighted, and I think this is confusing a little bit, because I was expecting something to be highlighted right away. Of course then I checked the docs, and the criteria, but sometimes users do not do this (like the first time I tried this myself :) ).

This issue is to improve this experience and possibly:

  1. Indicate this in the green alert
  2. Activate both inbound and outbound edges in the criteria

leandroberetta avatar Mar 15 '23 17:03 leandroberetta

@leandroberetta I would like to work on this issue, pls assign it to me.

shardulsrivastava avatar Apr 13 '23 23:04 shardulsrivastava

@leandroberetta I would like to work on this issue, pls assign it to me.

Yes, sure, thanks for jumping in!

leandroberetta avatar Apr 13 '23 23:04 leandroberetta

@shardulsrivastava , if you could provide an estimate of when you may have a PR please let us know. It is just for planning, there is no pressure. And if you have questions please let us know!

jshaughn avatar Apr 18 '23 13:04 jshaughn

@shardulsrivastava , Any updates here?

jshaughn avatar May 31 '23 13:05 jshaughn

@shardulsrivastava , are you still planning to work on this item?

jshaughn avatar Jun 23 '23 14:06 jshaughn