Kevin Wilson
Kevin Wilson
I enumerated several here: https://github.com/apache/arrow/issues/35166#issuecomment-2336776704 Clickhouse for instance just ignores precision.
@mapleFU I believe this is done now. Some notes on the diff: * The hash aggregates had to be updated as well (missed them in the first pass) * I've...
Two problems with just validating afterward: First, I'd expect in reasonable cases for the validation to fail. A sum of 1m decimals of approximately the same size you'd expect to...
Nice! I'm excited for the checked variants of sum and product! With the integer overflow example, I only meant to point out that the compute module currently allows overflows, so...
Hi @pitrou sorry for dropping the ball on this a bit earlier. Are you still interested in merging this at some point? I'm happy to explore some alternative options for...
Hey @pitrou i was thinking about this PR again recently. Would you still be interested in merging if I cleaned it up a bit?
Cool. I’m happy to do some more clean up or do a little work on creating the checked versions of the aggregates to push this along
That makes sense. From a sequencing stand point, should the checked versions come first or should we get this through first?
OK, I think I've correctly rebased (letting all the tests run now to figure out). I can remove the Decimal32/64 support once I check if I've rebased correctly. Will also...