phoenix_gon icon indicating copy to clipboard operation
phoenix_gon copied to clipboard

Published 20 hours ago • verified publisher icon khusnetdinov

fix for recent Phoenix.HTML

Open mayel opened this issue 3 years ago • 2 comments

mayel avatar Jan 15 '22 03:01 mayel

@khusnetdinov any chance to merge?

vtm9 avatar May 22 '22 08:05 vtm9

oops I accidentally pushed commits I intended to submit in a seperate PR, but it doesn't look like this repo is maintained anyway, for anyone reading you're welcome to use our fork directly (in which I've also merged the other open PR): https://github.com/bonfire-networks/phoenix_gon

mayel avatar Oct 02 '22 08:10 mayel

@mayel Update commit / PR and I will merge it

khusnetdinov avatar Mar 13 '23 18:03 khusnetdinov

Could you please create one commit

khusnetdinov avatar Mar 13 '23 18:03 khusnetdinov

Could you please create one commit

@khusnetdinov, I noticed this suggestion surfacing a couple of times. I'm curious: how may we handle this differently in order to keep this project evolving smoothly? As an idea, configuring a repository to enforce commit squashing for pull requests has worked well for us: it can lower the friction for contributors as well as balance contribution preferences for specific projects. Can this be an alternative solution for a win-win here too?

Here is what this configuration might look like:

Screenshot 2023-03-16 at 17 39 21

What do you think?

mariusbutuc avatar Mar 16 '23 21:03 mariusbutuc