Shailja Khurana

Results 95 comments of Shailja Khurana

@kidbrax thanks for reaching out. sounds useful to have.

Hi @tmokmss , thanks for reaching out. The property `mapPublicIpOnLaunch` in CDK docs states that - ``` The property mapPublicIpOnLaunch controls if a public IPv4 address will be assigned. This...

thanks @tmokmss for the clarification there. Your solution makes sense.

Hi @vcschapp , thansk for reaching out. I see the related issue of configuring cross-zone load balancing false for ALB target groups has been discussed here in detail s-https://github.com/aws/aws-cdk/issues/29866#issuecomment-2062550263 and...

@vcschapp , thanks so much for explaining that so well and getting back. I understood your point and confirm that its supported by cloudformation as well - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-targetgroupattribute.html#cfn-elasticloadbalancingv2-targetgroup-targetgroupattribute-key So till...

@wimlewis-amazon , thanks for highlighting the grammatical mistake in docs. it should be corrected to draw meaningful conclusion.

Hi @kensentor , thanks for reaching out. I tried to repro the issue with this minimal sample code - ```ts const opensearchDomain = new opensearch.Domain(this, 'OpenSearchDomain', { version: opensearch.EngineVersion.ELASTICSEARCH_7_10, capacity:...

@kensentor , yes that was the condition to repro the scenario. I changed the boolean variable -`enabled: false` and passed the `datNodeInstanceType: 'i4g.2xlarge.search'` and it failed during synth - However...

The rootcause for this is in the code - https://github.com/aws/aws-cdk/blob/366b4927c50168113dd4057f6255ab6c76278135/packages/aws-cdk-lib/aws-opensearchservice/lib/domain.ts#L1598 https://github.com/aws/aws-cdk/blob/366b4927c50168113dd4057f6255ab6c76278135/packages/aws-cdk-lib/aws-opensearchservice/lib/domain.ts#L1595C1-L1599C6 ```ts // Only R3, I3, R6GD, and IM4GN support instance storage, per // https://aws.amazon.com/opensearch-service/pricing/ if (!ebsEnabled && !isEveryDatanodeInstanceType('r3', 'i3',...

@aymen-chetoui I see that one of our core team members is already reviewing it. Thanks for submitting the PR. Let me know if any other help is needed.