khoj icon indicating copy to clipboard operation
khoj copied to clipboard

Improve docker-compose.yml

Open DPS0340 opened this issue 10 months ago • 3 comments

Improvements

  • Remove host port mappings on dependencies
  • Add 'restart: always'
  • Add default network for lookup by docker dns
  • Add extra_hosts for host.docker.internal lookup

DPS0340 avatar Jan 05 '25 06:01 DPS0340

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10005301 Triggered Generic Password a5c7315874907cdcda667bce98b0638378007fc7 docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jan 05 '25 06:01 gitguardian[bot]

Tested new docker-compose.yml on MacOS and Linux, verified that I'm able to start up the app and chat with models and conduct online search and execute code. Looks good!

@DPS0340 , feel free to share any context for additional testing you've done.

sabaimran avatar Jan 06 '25 21:01 sabaimran

@sabaimran

I'm able to use khoj obsidian plugin with sync :) Now, currently I don't have other considerations. Feel free to merge 😄

Screenshots

image image

DPS0340 avatar Jan 07 '25 01:01 DPS0340