Kevin H. Luu
Kevin H. Luu
> Does mergify bot provide such functionality? I think they do support auto rebase
@simon-mo Yes using a bash script can also help set up exit trap that cleans up the Docker network upon test failure. I can migrate this over
> sorry for the late review. is it already in the ci now? I added the multinode support to the template on `buildkite-ci`. After this PR is merged, you can...
I think this branch is stale (it was created when the script was not moved yet). Can you rebase this branch with main?
You might want to use `-e HF_TOKEN=$HF_TOKEN` instead of just `-e HF_TOKEN` and probably just `set -e` instead of `set -ex` so we don't print the token out (though leaking...
> Qwen shares the same architecture with Qwen-VL so I'd like to keep at least one test to check that the text-only version works correctly (there have been regressions in...
yep let me close the PR > I guess this isn't necessary anymore?
> Instead of hard-coding S3 paths, what if we used an environment variable (`VLLM_CI` or something) which, if set, will prepend `s3://vllm-ci-model-weights/` to the `model` and set `load_format="runai_streamer"`? hmm we...
> @simon-mo @khluu can I get help to unblock buildkite, thanks! which test do you need to unblock? of if you want permission to unblock tests, can I have your...
> > > @simon-mo @khluu can I get help to unblock buildkite, thanks! > > > > > > which test do you need to unblock? of if you want...