libcds icon indicating copy to clipboard operation
libcds copied to clipboard

A probability of segmentation fault

Open kazachkovaanna opened this issue 6 years ago • 3 comments

https://github.com/khizmax/libcds/blob/44c052bdb69aaf26d7010074547356c80e55421a/cds/intrusive/skip_list_nogc.h#L55-L61

Afrter m_arrNext = nullptr and before m_nHeight = 1 call of method next(uint nLevel) will cause segmentation fault. This to lines should be in reverse order

kazachkovaanna avatar Jan 13 '19 21:01 kazachkovaanna

@eugenyk please be aware we raised this issue

kazachkovaanna avatar Jan 13 '19 21:01 kazachkovaanna

@kazachkovaanna, in case of pull request with bugfix and stress or unit test, which show the bug, your brigade will be awarded an excellent mark on exam

eugenyk avatar Jan 15 '19 09:01 eugenyk

And a piece of advice: issue title should be more special, in your case now all segmentation faults in whole library can be addressed to your issue by name

eugenyk avatar Jan 15 '19 09:01 eugenyk