Scrutor icon indicating copy to clipboard operation
Scrutor copied to clipboard

Removing the recently added DecoratedType class to resolve issues wit…

Open DanHarltey opened this issue 2 years ago • 1 comments

…h some DI containers.

In case you want this.

DanHarltey avatar Jun 20 '22 21:06 DanHarltey

Codecov Report

Merging #176 (05f0db2) into master (40320c7) will increase coverage by 4.31%. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   64.57%   68.88%   +4.31%     
==========================================
  Files          25       23       -2     
  Lines        1276     1186      -90     
==========================================
- Hits          824      817       -7     
+ Misses        452      369      -83     
Impacted Files Coverage Δ
src/Scrutor/DecorationStrategy.cs 97.22% <94.11%> (-2.78%) :arrow_down:
src/Scrutor/ClosedTypeDecorationStrategy.cs 94.11% <100.00%> (ø)
src/Scrutor/OpenGenericDecorationStrategy.cs 95.45% <100.00%> (ø)
.../Scrutor/ServiceCollectionExtensions.Decoration.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40320c7...05f0db2. Read the comment docs.

codecov[bot] avatar Jun 20 '22 21:06 codecov[bot]

As mentioned in #175, I think I'd prefer to keep the decorator around and just try to patch the few places that fail. It's their fault for operating under false assumptions anyway.

BTW, I stumbled across this built-in TypeDelegator class, which already does a lot of what DecoratedType does 😅

khellang avatar Sep 08 '22 15:09 khellang