pt.darts icon indicating copy to clipboard operation
pt.darts copied to clipboard

It seems that there lost a parentheses in the compute_hessian function. -- (p-n) / 2.*eps

Open Frizy-up opened this issue 5 years ago • 1 comments

compute_hessian function last line : hessian = [(p-n) / 2.*eps for p, n in zip(dalpha_pos, dalpha_neg)] should be changed to: hessian = [(p-n) / (2.*eps) for p, n in zip(dalpha_pos, dalpha_neg)] according to the paper equation 8.

Frizy-up avatar Feb 12 '20 11:02 Frizy-up

I didn't find this at the beginning and have tried both these two. This indeed affects the update step but luckily not much on the result.

jkooy avatar Jul 22 '20 17:07 jkooy