khanlab
upgrade pybids to next version
This replaces PR #461 to perform the upgrade in pybids.
@pvandyken I'm getting unexpected errors in the tests:
FAILED snakebids/tests/test_generate_inputs.py::TestFilterBools::test_ambiguous_paths_with_extra_entities_leads_to_error - TypeError: root argument must be a pathlib.Path (or a type that supports casting to pathlib.Path, such as string) specifying the directory con...
complaining the that root argument is not Path or something that can be cast to path, e.g. string. But when I inspect the type of root it is class<str>, so not sure why it is failing.. Any ideas?
Proposed changes
Upgrades pybids to 0.18.0
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!
- [] Changes have been tested to ensure that fix is effective or that a feature works.
- [ ] Changes pass the unit tests
- [ ] I have included necessary documentation or comments (as necessary)
- [ ] Any dependent changes have been merged and published
Notes
There is actually pybids 0.19.0 now, so could go all the way there, the change I needed (fixes for cloud uri parsing) was in pybids 0.18.0..
All of the tests get messed up with the filesystem mock library, which is incompatible with pybids use of universal pathlib. I had started trying to remove the fs mock in tests that call phones, but haven't had time to finish yet.
