rspec-graphql_matchers icon indicating copy to clipboard operation
rspec-graphql_matchers copied to clipboard

Update to use #to_type_signature instead of #to_graphql

Open RobinDaugherty opened this issue 3 years ago • 5 comments

graphql 1.13.1 deprecated #to_graphql, making this change necessary.

#to_type_signature seems to have been added in ruby-graphql 1.8.3 so this shouldn't be a breaking change for most users.

RobinDaugherty avatar Jan 05 '22 23:01 RobinDaugherty

This fixes #42 for us.

BoboFraggins avatar Jan 28 '22 16:01 BoboFraggins

@khamusa can you please merge and release this? Please let me know if I can help.

RobinDaugherty avatar Feb 13 '22 17:02 RobinDaugherty

Is this the only change holding this gem back from upgrading to GraphQL-Ruby 2.0?

Sh1ken avatar Feb 22 '22 11:02 Sh1ken

The version range for graphql in the gemspec also needs to be updated, at the very least.

MrJoy avatar Mar 21 '22 17:03 MrJoy

Is this the only change holding this gem back from upgrading to GraphQL-Ruby 2.0?

Some of the specs will need to be updated as well.

Edit: and this line doesn't work with 2.x: https://github.com/khamusa/rspec-graphql_matchers/blob/master/lib/rspec/graphql_matchers/types_helper.rb#L9

djberg96 avatar Aug 24 '22 14:08 djberg96

Just starting a new gig, and seeing these deprecation warnings. What's the status on this MR? I'd love to help if I can.

liveh2o avatar Mar 08 '23 22:03 liveh2o

Any news on this one?

tdgs avatar Mar 11 '23 20:03 tdgs

@khamusa thanks for writing this gem! Are you still actively maintaining this?

tdgs avatar Mar 11 '23 20:03 tdgs

I am trying to get a hold of @khamusa via other channels to take over maintaining of this gem.

phikes avatar Apr 16 '23 11:04 phikes

Thanks for all the contributions, and I apologize for disappearing.

I have merged the PR, fixed the tests, did some extra cleanup, and updated the gemspec versions after testing against all minor versions. Version 1.4.0 has been published. I'll now investigate what's needed to achieve compatibility with graphql-ruby 2+

khamusa avatar Apr 16 '23 16:04 khamusa

Amazing, welcome back und thanks for putting in the work :)

phikes avatar Apr 16 '23 18:04 phikes