Athan

Results 953 comments of Athan

> Because there is a possibility they might not want to actually quit so it's better to confirm if they are, before prompting them if they want to save..? If...

@Snehil-Shah Is it possible to avoid the second `In [3]:` input prompt?

> the benchmarks and tests will essentially be similar to `ndarray/base/assign` Yes, I think so.

@gunjjoshi Yes, I think only using `fmod` in the C implementation is the path forward here.

> we could use the base package equivalents We should go ahead and make those changes. Too easy to forget to do them later.

> Maybe we can handle these two special cases manually in code? Not sure if a robust solution exists @Snehil-Shah I'll defer to your judgement on that.

@Snehil-Shah Gentle ping regarding resolving the above comments.

> I don't see a way out @Snehil-Shah Maybe the way out is just clearly documenting that overlap may happen and that there is likely also going to be some...

@Snehil-Shah Let's punt updating the docs, and let the keybindings fly under the radar for the time being while we test out, and then we can add to docs in...