Athan

Results 562 comments of Athan

Re: separate files. Yeah, I don't know if having them in the same file actually achieves much, especially if the respective lists are long. It would just create a long...

I've updated the OP with some updates. Re: `data.js`. I've added a [comment](https://github.com/stdlib-js/stdlib/blob/62cb2f0ea67ad09deb990d6e86e236785c848856/lib/node_modules/%40stdlib/strided/math/special/abs/lib/data.js#L34) pointing to the `types.json` file. Re: heuristics. I tried adding a heuristic; however, I encountered unexpected results....

I believe `isCallable` is intended to be more generic (see [here](https://github.com/inspect-js/is-callable/blob/680a8839071bf36a419fe66e1ced7a3303c27b28/test/index.js)). For practical purposes in the project, `isFunction` should suffice for input validation. However, for checking for other function flavors,...

Re: missing contractions. Some of the entries in your list are already present in the contractions file. E.g., [`wouldn't've`](https://github.com/stdlib-js/stdlib/blob/6ba862b89d0b35e2c03024942ad234ecb2d0acc8/lib/node_modules/%40stdlib/nlp/expand-contractions/lib/contractions.json#L137), [`mightn't've`](https://github.com/stdlib-js/stdlib/blob/6ba862b89d0b35e2c03024942ad234ecb2d0acc8/lib/node_modules/%40stdlib/nlp/expand-contractions/lib/contractions.json#L66).

@Planeshifter Is there a reason for the `what has/is` [entry](https://github.com/stdlib-js/stdlib/blob/6ba862b89d0b35e2c03024942ad234ecb2d0acc8/lib/node_modules/%40stdlib/nlp/expand-contractions/lib/contractions.json#L114)?

Re: fancy apostrophe. That should be possible to handle in the `@stdlib/nlp/tokenize` package.

@titanism One recent update: @Planeshifter added initial support for expanding acronyms (see https://github.com/stdlib-js/stdlib/tree/c624a5eb4bca8f4f3d45e01bcc4eeee41652e3ba/lib/node_modules/%40stdlib/nlp/expand-acronyms). This may help to avoid mixing contraction/acronym concerns.

For string distance functions, in the `@stdlib/string` namespace. I believe one of the initial reasons for not including Levenstein, Hamming, and others, was whether we needed to expose generic interfaces....

@jrreed83 Awesome!!!!!!!!!! Thank you so much for working on this!

Let's follow Python and Mathematica and go with `factorial2`.