Krishna Pai comments

Results 51 comments of


                                            Krishna Pai

Download source code archive directly for ubuntu and macos setup

@liujiayi771 I havent noticed any particular slowness with git and it seems roughly equivalent to download. The advantage of using git is that its probably a little more secure than...

Linking fbthrift with version v2024.02.26.00 unresolved symbols with gcc11 or later

@czentgr Feel free to open a PR upgrading it, I will help merge it.

Fix the issue that the splits cannot be skipped for some special case

@yingsu00 Can you fix the conflict before I start the merge process ?

Remove unused headers in base/Exceptions.h

@majetideepak This fails in a bunch of places internally due to fmt errors saying type not being formattable. Have had to fix each place individually. Hoping to finish it soon.

AggregationFuzzer: Remove functions with nullptr in custom verifier.

cc: @kevinwilfong

Remove AggregationTestBase::allowInputShuffle_ member variable

cc: @kevinwilfong

GCS Set a default policy to retry failures

cc: @majetideepak

Support complex type 'compare' in 3-arg min_by and max_by Presto aggregates

Thank you for this @f0rest9999 ! This PR will take me a bit of time, please give me a couple of days to review.

Support complex type 'compare' in 3-arg min_by and max_by Presto aggregates

> Have you run Aggregation Fuzzer using Presto as source before? In the process of running, I found some problems. @mbasmanova @kgpai > > And when I run max_by, I...

[WIP] Add support for installing and build dependencies, install folly using FetchContent

Hi @Yohahaha , Velox is moving towards hermetic builds, we are aiming to support dependencies installed on the system and also dynamically downloading and building if not present on system....