Krishna Pai

> Hi Raul, the f4d repository is historical (that was what Velox was called internally before being opensourced). It no longer exists and the instructions have to be updated. I...

Thanks again @raulcd . Looks good ; I have still some questions around the macro flags - but I am going to start testing this on an M1 later today...

@raulcd I suspect because linux-build builds against a smaller subset of velox. adapters and benchmarks build additional stuff that is not built by linux-build.

FYI - Testing on a mac m1, ran fine at first because of preinstalled folly. Deleted the /usr/local install of folly and now I see this : ``` -- Found...

@raulcd Validated that the M1 build works after adding the undef-prefix flags. LGTM , going to start the merge process.

@raulcd Please give me a day or two to merge this.

@raulcd Going to merge this today.

LG from my end; I also validated that protobuf version works on TA images. Please get approval from @majetideepak before I can start the merge process.

@karteekmurthys Some minor nits, hoping to merge this today.

Thanks @ChengjieLi28 , I am working on a fix in this PR: https://github.com/facebookincubator/velox/pull/2318