Kamil Gabryjelski
Kamil Gabryjelski
/testenv up FEATURE_DASHBOARD_VIRTUALIZATION
Thank you for the feedback! @hushaoqing @villebro Removing charts after scrolling them out of view was a conscious decision in order to reduce the number of nodes in DOM tree....
> One reason to render only visible items is memory footprint. Many virtualization libraries use that approach. That being said, may I suggest using pre-defined values for the feature flag...
> I'm getting weird performance issues (i.e. the browser freezing) but i'll try it again in a bit and see if it's just a fluke. If you're getting perf issues...
> > Do we have an established pattern for 3-state feature flags? > > I'm not aware of one, and it might be worth mentioning that a lot of companies...
@rusackas @michael-s-molina Updated the PR: 1. Make `DASHBOARD_VIRTUALIZATION` an enum config instead of a feature flag 2. `VIEWPORT` mode - remove charts that are not in view; `PAGINATED` - persist...
Unfortunately I can't start a testenv with virtualization since now it's a config instead of a feature flag, so if you want to test manually, you need to pull my...
Thank you all for feedback and suggestions! @justinpark I'm not sure if delaying queries is a better solution. Queries are initialized in the order in which the charts are placed...
@michael-s-molina @justinpark @geido @villebro @hushaoqing @rusackas @ktmud Thank you all for feedback and suggestions... and your patience. I updated the PR - now the charts render when they are 1vh...
/testenv up FEATURE_DASHBOARD_VIRTUALIZATION