kfr icon indicating copy to clipboard operation
kfr copied to clipboard

Filter's order

Open meiyasan opened this issue 3 years ago • 2 comments

Hello @dlevin256 ,

Is there any plan in KFR5.0 to compute the filter's order based on gPass/gStop parameters like in SciPy ? https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.ellipord.html (instead of providing an integer N)

This is something I am using everyday that is very useful. At this time I have to guess the order (or compute it myself based on dB variations I want).

meiyasan avatar Oct 24 '22 06:10 meiyasan

I just pushed a commit I implemented last week and got tested this week. https://github.com/xKZL/kfr/commit/16b2702850a34b3bfe36550a2a2ef7c58b5e76ce

This is not kfr style again, sorry about that. I hope this might enhance the use of this library.

meiyasan avatar Oct 28 '22 05:10 meiyasan

Hello Marco,

Computing the filter order is definitely a good feature for KFR 5.x. Thank you for the contribution.

dancasarin avatar Oct 28 '22 14:10 dancasarin