rcpp_progress icon indicating copy to clipboard operation
rcpp_progress copied to clipboard

all R functions described in the doc are missing

Open kforner opened this issue 4 years ago • 8 comments

e.g. RcppProgress:::test_sequential

kforner avatar May 29 '20 08:05 kforner

Indeed. I was looking for RcppProgress:::CxxFlags(). Are there plans to (re-) add the R functions?

bitbacchus avatar Sep 02 '20 09:09 bitbacchus

just need the time :( I welcome any contribution

kforner avatar Sep 02 '20 10:09 kforner

Thanks for your quick response @kforner

Can you give me a hint where and why they went missing? I'd have a look then.

Right now the Reference manual on CRAN refers at least to CxxFlags(), while it's missing in the CRAN version.

bitbacchus avatar Sep 02 '20 10:09 bitbacchus

It seems that the last commit that contained these is: https://github.com/kforner/rcpp_progress/tree/d9f04c68387ca85dc04d36adfe3c355c25cac578/R I don't remember exactly why I removed them. I probably forgot that they were mentioned by the doc.

kforner avatar Sep 02 '20 11:09 kforner

Dear @kforner

this seems to work. Before my PR, I'm thinking about changing some minor things:

  • export the test_* functions to the package namespace
  • use Roxygen to manage the namespace
  • add an RStudio .Rproj file and an .Rbuildignore file to the repo

Would you be happy with these? This would just be a convenience for me, but I have no strong opinion if you don't like it.

Best, Sebastian

bitbacchus avatar Sep 03 '20 09:09 bitbacchus

good

use Roxygen to manage the namespace

I think this is overkill, add a dependency and an extra step for building it. (but I like roxygen ;) )

.Rbuildignore file to the repo

ok

.Rproj

This is personal and should not be part of the project. For example I do not use rstudio.

kforner avatar Sep 03 '20 09:09 kforner

use Roxygen to manage the namespace

I think this is overkill, add a dependency and an extra step for building it. (but I like roxygen ;) )

Roxygen is just used to generate the NAMESPACE file and the documentation, of course. There is no need to have Roxygen as a dependency. Its no effort at all, I'll just do it and you can decide on this part later.

.Rbuildignore file to the repo

ok

.Rproj

This is personal and should not be part of the project. For example I do not use rstudio.

agree.

bitbacchus avatar Sep 03 '20 09:09 bitbacchus

ok

kforner avatar Sep 03 '20 10:09 kforner