Kyle Cripps
Kyle Cripps
@ajwalton @fruffy Ok but it seems like the precedent before this PR was to not add such tests when changing the behavior of options such as e.g. `--Werror` / `--Wdisable`,...
Sorry for all of the updates. The PR is now ready for review (and I will squash all commits when merging).
> > @ajwalton @fruffy Ok but it seems like the precedent before this PR was to not add such tests when changing the behavior of options such as e.g. `--Werror`...
> @fruffy I agree that we should build such testing mechanism. I am just saying that it can and should be done independently in a different PR. I opened https://github.com/p4lang/p4c/issues/4907...
Does anyone else want to review this? If not, I'll probably merge this soon.
@sepanchi JFYI - This may be a good one for you to work on if you have time :)
#5123 added such a mechanism and https://github.com/p4lang/p4c/pull/5175 adds tests for functionality that was added by PRs #4366 and #4894.
> In the original reproducer above, the unused __xyz() declares two hasReturn variables, and UniqueNames does not make their names unique, which causes the error. @oleg-ran-amd Why does it not...
See https://github.com/p4lang/p4c/pull/4900#issuecomment-2356645808
@AlexeyAliev You might want to look at this