Kashif Faraz

Results 26 comments of Kashif Faraz

Thanks for the changes, @FrankChen021! This makes the error responses much cleaner! I had a couple of minor suggestions: - In `ResponseStatusExceptionMapper`, consider changing the signature of method `.toResponse()` to...

Sure, @FrankChen021 . Sorry for the delay on this. Will take a look this week.

+1, I have noticed this one too. It can also be seen in the logs of #12747

This is an interesting fix, @capistrant ! Some observations: A) For consistency with the read from config manager, I would have advised that you update the method `DruidDynamicConfigsResource.setDynamicConfigs()` to write...

@didip , please create an issue for the `http` loading discrepancies if you have been facing them recently.

@panhongan , thanks for the fixes, there seem to be some genuine CI failures. Could you please take a look?

Thanks for the update, @paul-rogers ! I will take another look today and merge this.

@317brian , thanks for the quick fix! You might need to update some other files to fix broken links. From the failed build logs: ``` Could not find anchor '#post-5'...

Haven't reviewed the PR thoroughly yet but it seems pretty useful and would make test cases much more readable. A couple of first glance comments: - I suppose the only...