django-allowedsites icon indicating copy to clipboard operation
django-allowedsites copied to clipboard

Django 1.11+ compatibility

Open nanuxbe opened this issue 6 years ago • 2 comments

Hi, it's been a while :-)

django-allowedsites started to be a bit wonky with Django 1.11 but still kinda worked if you restarted the wsgi app after adding new sites (the test suite fails though) so I didn't really look much into it at the time but things seem to have gone worse with Django 2.x

Django 1.11 is still LTS for at least 6 months or so. So I'm thinking of looking into making things work smoothly again in 1.11 some time in the next few days. I will also check if there is any way of making things compatible with the 2.x series.

I think I still have the commit bit on this repo but whether I have it or not I still wanted to check in with you first.

Have a great day

nanuxbe avatar Oct 08 '19 10:10 nanuxbe

Hey, it certainly has! Hope you're keeping well.

django-allowedsites started to be a bit wonky

wonky is my raison d'être. I'd be infinitely surprised if it weren't.

So I'm thinking of looking into making things work smoothly again in 1.11 some time in the next few days. I will also check if there is any way of making things compatible with the 2.x series.

And that's why you're a better steward than I :)

You should still have the commit bit here, and I think you have ownership of the package name on PyPI. I'm still happy with that being the case, not least because you and some few others actually seem to use it, where I never ended up in a position to do so.

If you want any questions about why I did things a certain way, do ask and I'll try and recall :) If you want me to look at it as part of some sort of review process, ditto.

If I've not said previously, I'm grateful you took the time and care to look after it, in whatever capacity you've felt able.

kezabelle avatar Oct 09 '19 12:10 kezabelle