Keryn Knight

Results 59 comments of Keryn Knight

Computers forever proving they're hard; I see an improvement, as you did, though the magnitude is different: ``` In [9]: %timeit csrf_input_new(r) 74.5 µs ± 516 ns per loop (mean...

Well that's puzzling ... some of the 3.10 builds pass and others don't?! and `view_tests.tests.test_debug.ExceptionReporterTests.test_reporting_frames_for_cyclic_reference` failed but only for `postgres,bionic-pr,python3.10` ... Colour me confused. ----- Edit: Under _my_ 3.10 install,...

> Those two 3.10 runs that were successful were for `mysql_gis`. They _only_ ran the tests under `gis_tests`. Ah, of course! Thank you for that. That still leaves me scratching...

Aha, happily for me, d05ab13c56849ed09d02c1f188b7f47f0c090a2a landed and made the output consistently `functools.partial` across versions. And the unrelated failure was maybe transient or maybe leaky because of one of the other...

I definitely need to revisit this, leave it with me? Primarily I think the test coverage was to show the "current" behaviour that was otherwise implicit in some sections (e.g....

Yeah, I'm happy to do so. It's mostly still marked as WIP/needs improvement to get eyes on it to decide on how/if it should be implemented (e.g: use a `@contextmanager`...

**TL;DR: I've tidied it up, and it's ready to be discussed and/or independently benchmarked/profiled. There are example usages of the API in addition to the API itself.** ------ Alright so,...

FWIW, instrumenting `BaseContext.__getitem__` like so: ``` for i, d in enumerate(reversed(self.dicts)): if key in d: print(f'found at,{i},for context length,{len(self.dicts)}') ``` and running the test suite will give you ... 2.5million...

Example stacktrace: ``` Traceback (most recent call last): File "/PATH/python3.5/site-packages/django/core/handlers/exception.py", line 41, in inner response = get_response(request) File "/PATH/python3.5/site-packages/django/core/handlers/base.py", line 217, in _get_response response = self.process_exception_by_middleware(e, request) File "/PATH/python3.5/site-packages/django/core/handlers/base.py", line...

[Related upstream ticket](https://code.djangoproject.com/ticket/30312), FWIW.