ccube icon indicating copy to clipboard operation
ccube copied to clipboard

Possible typo in SortClusters function

Open nvolkovaGEL opened this issue 1 year ago • 1 comments

Hello,

We've been going through the code to understand the potential variability within the model, and spotted that the model$logResponsibility is assigned with model$responsibility in this line - is that a typo, or is there any reason to do specifically that?

if (!is.matrix(model$responsibility) ) {
  model$responsibility <- t ( as.matrix(model$responsibility)  )
  model$logResponsibility <- t ( as.matrix(model$responsibility)  )
}

https://github.com/keyuan/ccube/blob/2345c3a785eed379116d800514d8a4ec02a4d811/R/ccube.R#L39

Thank you in advance.

Best regards, Nadezda

nvolkovaGEL avatar Dec 12 '24 16:12 nvolkovaGEL

Hi Nadezda,

You are right. It is indeed a typo.

Best, ke

keyuan avatar Dec 12 '24 22:12 keyuan