keystone
keystone copied to clipboard
Allow admin UI base path customization in config
Added (or rather uncommented) a config variable to set the admin UI base path and set the conf accordingly in createAdminUIMiddleware.ts
. Thanks to @thekarinka for help in making this work!
🦋 Changeset detected
Latest commit: 07c2238d9ed76d60fb356087448679b003898d90
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 15 packages
Name | Type |
---|---|
@keystone-6/core | Minor |
@keystone-6/auth | Major |
@keystone-6/cloudinary | Major |
@keystone-6/fields-document | Major |
@keystone-6/session-store-redis | Major |
@keystone-6/example-auth | Patch |
@keystone-6/examples-app-basic | Patch |
@keystone-6/example-ecommerce | Patch |
@keystone-6/example-graphql-api-endpoint | Patch |
@keystone-6/example-roles | Patch |
@keystone-6/example-sandbox | Patch |
@keystone-6/example-testing | Patch |
@keystone-6/example-with-auth | Patch |
@keystone-6/website | Patch |
@keystone-6/example-document-field | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/3T1jHnB4hyrn6yTrn3USfNMZycEz
✅ Preview: https://keystone-next-docs-git-fork-moselhy-admin-basepath-keystonejs.vercel.app
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Related https://github.com/keystonejs/keystone/discussions/5804
I haven't tested this yet, but wouldn't there also need to be changes made to the nextjs build step for the admin ui?
from the nextjs basePath
docs:
Note: this value must be set at build time and can not be changed without re-building as the value is inlined in the client-side bundles.
Quick note to say we're looking into this. It's not highest priority, but we know many in the community would like to see this unlocked.
Bump here +1
Really would be useful to have this rather than find a hacky workaround
Really would be useful to have this rather than find a hacky workaround
I have the same issue. What workaround do you use ? I see only one to deploy to a dedicated domain. I want to extended express server to serve angular application close to the backend (keystonejs)
Bump +1
Replaced by https://github.com/keystonejs/keystone/pull/8545, unfortunately this change wasn't so subtle and required additional testing and development to ensure compatibility with existing projects.
Thanks @moselhy for starting the feature :yellow_heart: