keystone icon indicating copy to clipboard operation
keystone copied to clipboard

Allow admin UI base path customization in config

Open moselhy opened this issue 3 years ago • 9 comments

Added (or rather uncommented) a config variable to set the admin UI base path and set the conf accordingly in createAdminUIMiddleware.ts. Thanks to @thekarinka for help in making this work!

moselhy avatar Dec 31 '21 22:12 moselhy

🦋 Changeset detected

Latest commit: 07c2238d9ed76d60fb356087448679b003898d90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@keystone-6/core Minor
@keystone-6/auth Major
@keystone-6/cloudinary Major
@keystone-6/fields-document Major
@keystone-6/session-store-redis Major
@keystone-6/example-auth Patch
@keystone-6/examples-app-basic Patch
@keystone-6/example-ecommerce Patch
@keystone-6/example-graphql-api-endpoint Patch
@keystone-6/example-roles Patch
@keystone-6/example-sandbox Patch
@keystone-6/example-testing Patch
@keystone-6/example-with-auth Patch
@keystone-6/website Patch
@keystone-6/example-document-field Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 31 '21 22:12 changeset-bot[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/3T1jHnB4hyrn6yTrn3USfNMZycEz
✅ Preview: https://keystone-next-docs-git-fork-moselhy-admin-basepath-keystonejs.vercel.app

vercel[bot] avatar Dec 31 '21 22:12 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Dec 31 '21 22:12 codesandbox-ci[bot]

Related https://github.com/keystonejs/keystone/discussions/5804

dcousens avatar Feb 10 '22 00:02 dcousens

I haven't tested this yet, but wouldn't there also need to be changes made to the nextjs build step for the admin ui?

from the nextjs basePath docs:

Note: this value must be set at build time and can not be changed without re-building as the value is inlined in the client-side bundles.

acburdine avatar Feb 16 '22 15:02 acburdine

Quick note to say we're looking into this. It's not highest priority, but we know many in the community would like to see this unlocked.

raveling avatar Feb 17 '22 05:02 raveling

Bump here +1

Pei116 avatar May 24 '22 13:05 Pei116

Really would be useful to have this rather than find a hacky workaround

beemstream avatar Aug 01 '22 18:08 beemstream

Really would be useful to have this rather than find a hacky workaround

I have the same issue. What workaround do you use ? I see only one to deploy to a dedicated domain. I want to extended express server to serve angular application close to the backend (keystonejs)

glani avatar Aug 02 '22 18:08 glani

Bump +1

junaid33 avatar Oct 24 '22 18:10 junaid33

Replaced by https://github.com/keystonejs/keystone/pull/8545, unfortunately this change wasn't so subtle and required additional testing and development to ensure compatibility with existing projects.

Thanks @moselhy for starting the feature :yellow_heart:

dcousens avatar May 15 '23 04:05 dcousens