keystone icon indicating copy to clipboard operation
keystone copied to clipboard

PNG in Custom Logo causes silent build failure.

Open gwyneplaine opened this issue 3 years ago • 2 comments

Follow the custom logo flow and add a png

/** @jsxRuntime classic */
/** @jsx jsx */
import Link from 'next/link';
import { jsx, H3 } from '@keystone-ui/core';
import Logo from './Logo.png';

export const CustomLogo = () => {
  return (
    <H3>
      <img src={Logo.src} />
      <Link href="/" passHref>
        <a
          css={{
            // TODO: we don't have colors in our design-system for this.
            backgroundImage: `linear-gradient(to right, #0ea5e9, #6366f1)`,
            backgroundClip: 'text',
            lineHeight: '1.75rem',
            color: 'transparent',
            verticalAlign: 'middle',
            transition: 'color 0.3s ease',
            textDecoration: 'none',
          }}
        >
          LegendBoulder After
        </a>
      </Link>
    </H3>
  );
};

Run yarn build

The build should complete successfully, it instead hangs indefinitely. This flow works fine in yarn dev

Screen Shot 2021-12-14 at 9 27 39 am

Replicated both within the keystone repo and in an external reproduction. Replicated in node 14.17, but appears to be the case in multiple node versions. Likely a next build issue, that isn't being surfaced.

Original report here: https://keystonejs.slack.com/archives/C01STDMEW3S/p1639128427068300

gwyneplaine avatar Dec 13 '21 22:12 gwyneplaine

Cannot reproduce, can you provide the .png used?

dcousens avatar Dec 22 '21 04:12 dcousens

I have the same issue with a png logo.

fkrauthan avatar Jun 21 '22 06:06 fkrauthan