keystone icon indicating copy to clipboard operation
keystone copied to clipboard

Add update many options on list

Open gautamsi opened this issue 4 years ago • 6 comments
trafficstars

I needed this and thought it would be good idea to bring this feature back.

  • I would still love to see how to make this on left side to distinguish a update many and create form

adding comments where it may need improvements.

I would appreciate this in next release.

NO TESTS written, I would need help with this.

keystone-update-many

gautamsi avatar Oct 20 '21 21:10 gautamsi

🦋 Changeset detected

Latest commit: 68a2b2e9e2de364ee68e47367e6c12dd131a9596

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@keystone-ui/fields Minor
@keystone-next/example-assets-cloud Minor
@keystone-next/example-assets-local Minor
@keystone-next/example-auth Minor
@keystone-next/examples-app-basic Minor
@keystone-next/example-ecommerce Minor
@keystone-next/example-embedded-nextjs Minor
keystone-next-app Minor
@keystone-next/example-roles Minor
@keystone-next/example-sandbox Minor
@keystone-next/example-blog Minor
@keystone-next/example-custom-admin-ui-logo Minor
@keystone-next/example-custom-admin-ui-navigation Minor
@keystone-next/example-custom-admin-ui-pages Minor
@keystone-next/example-custom-field Minor
@keystone-next/example-custom-field-view Minor
@keystone-next/example-default-values Minor
@keystone-next/example-document-field Minor
@keystone-next/example-extend-graphql-schema Minor
@keystone-next/example-json-field Minor
@keystone-next/example-rest-api Minor
@keystone-next/example-task-manager Minor
@keystone-next/example-testing Minor
@keystone-next/example-virtual-field Minor
@keystone-next/example-with-auth Minor
@keystone-next/keystone Minor
@keystone-next/test-projects-basic Minor
@keystone-next/test-projects-crud-notifications Minor
@keystone-next/auth Major
@keystone-next/cloudinary Major
@keystone-next/fields-document Major
@keystone-next/session-store-redis Major
@keystone-next/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 20 '21 21:10 changeset-bot[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/87pXivdK3NCi4QVFbbWiSHEPKL8A
✅ Preview: https://keystone-next-docs-git-fork-gautamsi-add-upda-0cb39f-keystonejs.vercel.app

vercel[bot] avatar Oct 20 '21 21:10 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Oct 20 '21 21:10 codesandbox-ci[bot]

Hi @gautamsi !

Thanks for taking the time to make this pull request, it addresses a problem that we've been thinking about since K5. Unfortunately a primary issue with the pull request as is, is that hideUpdate is not conceptually compatible with the listView and itemView fields and their defaultFieldMode configuration. If we merge this pull request now, we'll probably have to introduce breaking changes soon thereafter to reconcile that. For the upcoming Keystone 6 GA release, we're taking the position of trying to keep the APIs as stable as we can, so in the interest of not immediately introducing breaking changes, I don't think we'll be able to land this before then; but it is something we should iterate on soon there-after.

What this pull request has so clearly pointed out is that the listView and itemView might not be complete in their capabilities to configure these concepts; and that probably means they need re-visiting.

Open to your feedback on this

dcousens avatar Oct 26 '21 00:10 dcousens

@dcousens I get your point. Should we remove this hideUpdate option to get this PR approved.

I think we can worry about complexity later and get this feature before GA.

gautamsi avatar Oct 26 '21 06:10 gautamsi

The problem is that the changes in this pull request nullify the underlying semantics of the listView and itemView fields by introducing a state where you are modifying items through the list view.

I don't know what the answer is, but, as mentioned, this pull request has clearly pointed that the listView and itemView fields are not complete in their capabilities for this use-case; and that probably means they need re-visiting.

dcousens avatar Oct 27 '21 00:10 dcousens

I use my own fork https://github.com/k6js/k6js for my projects which includes this feature. That fork is updated whenever I want to update to latest keystone for feature or fixes.

lot of conflicts now, will close this and let core team decide the course of action.

gautamsi avatar Aug 15 '22 14:08 gautamsi

@gautamsi yes, I think we can close this - but please know that the feature is not being abandoned out of the gate.

We are aware that bulk item management is a strong use case for Keystone, and do we want to support that use case. If in our implementation we take any inspiration or code from this pull request, we'll ensure to add credit to yourself :+1:.

dcousens avatar Aug 16 '22 01:08 dcousens