keystone-classic
keystone-classic copied to clipboard
letsencrypt-express has been renamed to greenlock-express
letsencrypt-express has been renamed to greenlock-express and will now be maintained as such.
hey, was looking at doing this, but it isn't clear whether or not they have a trademark for greenlock and i don't know how that might affect us..?
any thoughts? thanks
@kennedybaird Trademarks are fine as long as there is proper attribution. For example, Node.js and MongoDB are also registered trademarks. The greenlock-express
package indicates it is licensed under MIT or Apache 2.0, and that Greenlock™ is a trademark of AJ ONeal.
As part of this task, I think we also need to:
- Consider if the Keystone configuration option should be renamed (or aliased?) to reflect the change in middleware name. Renaming is probably more obvious, although
greenlock-express
still provides an API for the Let's Encrypt service. - Add tests. It doesn't look like there are any tests for this functionality via Keystone (although I may have missed them).
- Add documention to the Keystone 4 docs: http://keystonejs.netlify.com/documentation/configuration/server-options. It looks like the blog post Let’s Encrypt KeystoneJS! has the most detailed usage example outside of searching GitHub issues.
Are you currently using letsencrypt-express
with Keystone 4 beta? A good starting point would be confirming whether the functionality still works with the deprecated package.
If you'd like to discuss further, please also join us on the KeystoneJS Community Slack.
Regards, Stennie