Change Cloud Task header used to retrieve retries

[alachaum]

The X-CloudTasks-TaskExecutionCount header sent by Google Cloud Tasks and providing the number of retries outside of HTTP 503 (instance not reachable) is currently bugged and remains at 0 all the time.

Starting with 0.10.rc3 Cloudtasker uses the X-CloudTasks-TaskRetryCount header to detect the number of retries. This header includes HTTP 503 errors which means that if your application is down at some point, jobs will fail and these failures will be counted toward the maximum number of retries. A bug report has been raised with GCP to address this issue.

Once fixed we will revert to using X-CloudTasks-TaskExecutionCount to avoid counting HTTP 503 as job failures.

[alachaum]

Need to double check if GCP has fixed this recently. If they have, I'll switch the header. If they haven't, I'll just close the issue.

The last news from my bug report was that the current behaviour was "intended". In other words they just discarded the issue despite bug reports from two differences sources.

[geoffreyd]

It seems that your linked issue (154532072) is no longer available on Google's issue tracker. According to this issue, it seems a problem was acknowledged, and supposedly fixed. Hopefully that's the case.

[alachaum]

Thanks for the heads up @geoffreyd ! I'll give it another try to verify they actually fixed it. And if that's the case well.... I'll change the header used to detect retry counts! 🎉

PS: it seems my original issue got cleaned up on their side.

[alachaum]

It confirm that the X-Cloudtasks-Taskexecutioncount header is working properly. I'll change the header we use to detect the retry count in the next release.