KeyMapper icon indicating copy to clipboard operation
KeyMapper copied to clipboard

Brightness change interval is not linear

Open anaxonda opened this issue 4 years ago • 3 comments

Developer TODO (don't remove)

  • [ ] create new branch. put issue number at start of name if not a very quick fix.
  • [ ] write tests. put issue number in comment
  • [ ] add radio buttons for logarithmic/linear and explain why this is useful
  • [ ] update documentation
  • [ ] squash and merge
  • [ ] delete branch

Describe the bug The interval that brightness changes in one keypress is not what I would expect. Using volume keys to trigger (but also tried fingerprint sensor, same result). Brightness goes from minimum to 50% in one step, and then steps get increasingly smaller the brighter it gets (and same vice versa).

To Reproduce Steps to reproduce the behavior: Set trigger (tried fingerprint scanner and volume keys). Set action as increase or decrease brightness.

Upload a backup of your keymaps. Follow the guide here. https://temp.sh/ozSiC/key_maps_20211105-212158.zip

Expected behavior Brightness to increase at the same interval for every action trigger.

Smartphone (please complete the following information):

  • Device: Moto g7 Power
  • Android version: Android 11

Additional context Perhaps it related to https://old.reddit.com/r/GooglePixel/comments/97ir14/what_is_the_advantage_of_logarithmic_slider_for/

anaxonda avatar Nov 06 '21 02:11 anaxonda

Interesting. Key Mapper is telling the system to increase/decrease the brightness ±20 steps out of 255. I guess I would have to make Key Mapper increase/decrease the brightness logarithmically? I'm also not sure on which devices this happens so then it could potentially mess stuff up for existing users.

sds100 avatar Nov 07 '21 15:11 sds100

Interesting. Key Mapper is telling the system to increase/decrease the brightness ±20 steps out of 255. I guess I would have to make Key Mapper increase/decrease the brightness logarithmically? I'm also not sure on which devices this happens so then it could potentially mess stuff up for existing users.

You could have a toggle for the formula, just so the use has both options.

GL513 avatar Jan 30 '22 23:01 GL513

I don't know if this is useful information but sending key codes 220 and 221 through adb will increase and decrease the brightness by 10% instead of starting at 40% and getting progressively more gradual. I don't know if it's possible to simulate pressing those key codes through the app but it would make changing the brightness more consistent between devices.

I tried binding those key codes directly using the key code and key event actions but it didn't do anything.

xoger avatar Jul 21 '22 21:07 xoger